big-bro-watches-everything/devstar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow users with write permissions for issues to add attachments with API (#26837)

repo.diff.browse_source 
Fixes #24944

Since a user with write permissions for issues can add attachments to an
issue via the the web interface, the user should also be able to add
attachments via the API
This commit is contained in:
Zettat123
2023-09-01 23:35:38 +08:00
repo.diff.committed_by GitHub
repo.diff.parent 02efd99010
repo.diff.commit 04771b5ff7
repo.diff.stats_desc%!(EXTRA int=1, int=1, int=1)
repo.diff.download_patch repo.diff.download_diff Expand all files Collapse all files

2
routers/api/v1/repo/issue_attachment.go
repo.diff.view_file

@@ -344,7 +344,7 @@ func getIssueAttachmentSafeRead(ctx *context.APIContext, issue *issues_model.Iss
}
func canUserWriteIssueAttachment(ctx *context.APIContext, issue *issues_model.Issue) bool {
canEditIssue := ctx.IsSigned && (ctx.Doer.ID == issue.PosterID || ctx.IsUserRepoAdmin() || ctx.IsUserSiteAdmin()) && ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)
canEditIssue := ctx.IsSigned && (ctx.Doer.ID == issue.PosterID || ctx.IsUserRepoAdmin() || ctx.IsUserSiteAdmin() || ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull))
if !canEditIssue {
ctx.Error(http.StatusForbidden, "", "user should have permission to write issue")
return false